Skip to content

Updated the googleAnalytics plugin to take into account page reloads #27

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 9, 2020

Conversation

must
Copy link
Member

@must must commented Sep 9, 2020

No description provided.

@must must merged commit aa4ce29 into CONNECT-platform:master Sep 9, 2020
@must must deleted the ga-update branch September 9, 2020 11:48
@TysonMN
Copy link
Contributor

TysonMN commented Sep 9, 2020

// Coppied from https://github.com/bender2k14/tyson-williams-blog/blob/2501a6e55ebbf0e559d91ac1494ef2b412739c7d/.codedoc/components/GoogleAnalytics/plugin.tsx#L28
// Thumbs up to @bender2k14

You are welcome. Although, I wouldn't have gotten that far without help from @loreanvictor in CONNECT-platform/codedoc#68.

FYI, now I am trying to make this into a CODEDOC plugin in this repository. Still not sure how to do that.

@must
Copy link
Member Author

must commented Sep 9, 2020

It would be nice to have a ready made plugin that can be reused without much hassle. For now, we just needed a quick solution since we're publishing a new issue. I am also not sure how to publish plugins for Codedoc maybe @loreanvictor can elaborate.

@TysonMN
Copy link
Contributor

TysonMN commented Sep 9, 2020

Sounds good. @loreanvictor and I are in conversation about how to publish a CODEDOC plugin in

and

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants